Remove addVsocksHandler from loadSnapshotHandlerList

According to the firecracker OpenAPI specification [1], creating vsock devices is only a pre-boot request, so adding vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores vsocks anyways. Closes firecracker-microvm#506 1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678 Signed-off-by: Georgiy Lebedev <[email protected]>
CuriousGeorgiy · Sep 8, 2023 · 57869b1 · 57869b1
1 parent 4299558
commit 57869b1
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/handlers.go b/handlers.go
@@ -321,7 +321,10 @@ var loadSnapshotHandlerList = HandlerList{}.Append(
 	CreateLogFilesHandler,
 	BootstrapLoggingHandler,
 	LoadSnapshotHandler,
-	AddVsocksHandler,
+	// According to the firecracker OpenAPI specification, creating vsock devices is only a pre-boot request, so adding
+	// vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores
+	// vsocks anyways (firecracker-microvm/firecracker-go-sdk#506).
+	// AddVsocksHandler,
 )
 
 var defaultValidationHandlerList = HandlerList{}.Append(