Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null not working with maxSize #3

Closed
kevman opened this issue Dec 1, 2014 · 0 comments · Fixed by #9
Closed

Null not working with maxSize #3

kevman opened this issue Dec 1, 2014 · 0 comments · Fixed by #9
Labels
bug

Comments

@kevman
Copy link

kevman commented Dec 1, 2014

From the API reference: "Number (required) - Maximum file-size (in bytes). Use null for unlimited."

I tried it, but null for unlimited is not working. A number is required.
@gsuess gsuess added the bug label Dec 1, 2014
gsuess added a commit that referenced this issue Dec 1, 2014
@gsuess
#3 Max size 0 or null is now respected
343de4e
@gsuess gsuess mentioned this issue Dec 1, 2014
Merged
@gsuess gsuess closed this as completed in #9 Dec 1, 2014
gsuess added a commit that referenced this issue Dec 1, 2014
@gsuess
Merge pull request #9 from CulturalMe/#3-unlimited-file-size
827ebec 
#3 Max size 0 or null is now respected
astraw added a commit to strawlab/meteor-slingshot that referenced this issue Feb 1, 2015
@astraw
AWS: allow dots ('.') in bucket name during upload.
24d90fd 
Previously, HTTPS certificate validation would fail if dots were in
the bucket name because the bucketURL would then contain multiple
levels of subdomains (e.g. some.depth.of.domains.s3.amazonaws.com).

Now, the bucket name is not included in the domain name during
uploads, and the HTTPS certificate is valid even when dots are in the
bucket name.

Note that this commit does not fix the situation for downloads. This
is more complicated because of multiple ways of downloading a
file. With S3 alone there is CulturalMe#1 (
https://bucket-name.s3[-and-possibly-region].amazonaws.com/key ) and
the approach used by this commit for uploading CulturalMe#2 (
https://s3[-and-possibly-region].amazonaws.com/bucket-name/key ). Then
there is with a CDN, which would typically be something like CulturalMe#3 (
https://cdn-distribution-name.cloudfront.net/key ). A suitable
solution to create download URLs that allows dots in the bucket name
is not covered by this commit. To word around this present limitation,
construct your own download URL using options CulturalMe#1, CulturalMe#2 and CulturalMe#3 according
to your needs.
@astraw astraw mentioned this issue Feb 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3 Max size 0 or null is now respected CulturalMe/meteor-slingshot
2 participants
@kevman @gsuess