-
Notifications
You must be signed in to change notification settings - Fork 1
chore(mcp): remove deprecated graph aliases #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| ## [Unreleased] | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| ### Removed | ||||||||||||||||||||||||||||||||||||||
| - Remove the deprecated `graph-path`, `graph-orphans`, `graph-dangling`, and | ||||||||||||||||||||||||||||||||||||||
| `graph-stats` MCP compatibility aliases after the 5.0 bridge release. Use the | ||||||||||||||||||||||||||||||||||||||
| unified `graph(op=path|orphans|dangling|stats)` tool; `graph-neighbors` stays. | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| ### Changed | ||||||||||||||||||||||||||||||||||||||
| - `omind bench` now reports the exposed MCP tool count and serialized schema | ||||||||||||||||||||||||||||||||||||||
| token estimate so future surface changes remain measurable. | ||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+10
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Add blank lines after the new headings.
Proposed fix ### Removed
+
- Remove the deprecated `graph-path`, `graph-orphans`, `graph-dangling`, and
`graph-stats` MCP compatibility aliases after the 5.0 bridge release. Use the
unified `graph(op=path|orphans|dangling|stats)` tool; `graph-neighbors` stays.
### Changed
+
- `omind bench` now reports the exposed MCP tool count and serialized schema
token estimate so future surface changes remain measurable.📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.23.1)[warning] 10-10: Headings should be surrounded by blank lines (MD022, blanks-around-headings) [warning] 15-15: Headings should be surrounded by blank lines (MD022, blanks-around-headings) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||||||||||||||||||||||||||||||||||||||
| - **A genuine preflight miss auto-clears the per-turn gate instead of forcing a | ||||||||||||||||||||||||||||||||||||||
| manual consult.** Previously, when `retrieve.relevant_titles` found nothing | ||||||||||||||||||||||||||||||||||||||
| relevant to the turn's task, the gate stayed armed and demanded a | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -405,7 +405,7 @@ questions that previously matched nothing now return ranked answers. | |||||
| ```bash | ||||||
| omind search "why did release signing fail" --explain | ||||||
| omind reindex --index-only # refresh the derived index (search does this too) | ||||||
| omind bench # latency and token cost on your own vault | ||||||
| omind bench # latency, MCP schema size, and token cost | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Document both MCP surface measurements.
Proposed fix-omind bench # latency, MCP schema size, and token cost
+omind bench # latency, MCP tool count/schema size, and token cost📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| ``` | ||||||
|
|
||||||
| The index lives in the state directory, never in the vault — it is disposable | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,8 @@ def test_report_covers_latency_and_tokens(tmp_path: Path) -> None: | |
| report = bench.run(_vault(tmp_path), queries=("nebraska",)) | ||
| names = [m.name for m in report.measurements] | ||
| assert "notes in vault" in names | ||
| assert "MCP tools exposed" in names | ||
| assert "MCP tool schemas" in names | ||
| assert "index build (from scratch)" in names | ||
| assert "index refresh (no changes)" in names | ||
| assert any(name.startswith("search ") for name in names) | ||
|
|
@@ -44,6 +46,13 @@ def test_report_covers_latency_and_tokens(tmp_path: Path) -> None: | |
| assert {"ms", "tokens", "count"} <= units | ||
|
|
||
|
|
||
| def test_report_measures_the_reduced_mcp_surface(tmp_path: Path) -> None: | ||
| report = bench.run(_vault(tmp_path), queries=("nebraska",)) | ||
| by_name = {m.name: m.value for m in report.measurements} | ||
| assert by_name["MCP tools exposed"] == 13 | ||
| assert by_name["MCP tool schemas"] > 0 | ||
|
Comment on lines
+49
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win Protect the schema-token metric with a budget. The assertion 🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| def test_paging_is_reported_as_a_token_saving(tmp_path: Path) -> None: | ||
| report = bench.run(_vault(tmp_path), queries=("nebraska",)) | ||
| by_name = {m.name: m.value for m in report.measurements} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Reconcile the handoff status with
BACKLOG.md.This hunk removes
#177from the decision list, butAGENTS.mdstill says#174and#177were left open at Line 151 through Line 153. It also keeps#172as the remaining decision item, whileBACKLOG.mdmarks#172as done at Lines 36-40. Update the handoff to list only active decisions and shipped work consistently.🤖 Prompt for AI Agents