authFlowGenerator fix #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OzzieOrca
reviewed
Mar 28, 2019
src/routes/auth/authFlowGenerator.js
Outdated
| @@ -13,7 +13,7 @@ export const authFlowGenerator = ({ | |||
| completeAction, | |||
| includeSignUp = true, | |||
| }) => ({ | |||
| ...(includeSignUp && { | |||
| ...((includeSignUp && { | |||
There was a problem hiding this comment.
I think a ternary would read better here. With both && and || there is more to reason about.
Also I'm confused why this is an issue. Doing this in the Chrome console seems to work.
Maybe Babel compiles it weirdly or JavaScriptCore runs it differently...
There was a problem hiding this comment.
It does run differently on devices.
This is the issue I found relating to this facebook/react-native#19009
I agree that ternary would be better here. ...(includeSignUp ? {...} : {})
There was a problem hiding this comment.
Okay, I will do that.
This error was interesting-- the red screen stated that this was a "performance optimization" and not a "spec complaint" yet it still would not run it.
OzzieOrca
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.