Skip to content

Deleting wrong tab #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmktomato opened this issue Apr 6, 2018 · 8 comments
Closed

Deleting wrong tab #177

mmktomato opened this issue Apr 6, 2018 · 8 comments

Comments

@mmktomato
Copy link
Contributor

I found a bug aboud deleting tabs.

VTR: 0.10.0
FireFox: 59.0.2
OS: macOS 10.13.4

what I did

  1. Add many tabs to overflow the tab panel.
  2. In last 3 tabs, open any urls.
    1. Bing
    2. Yahoo
    3. Google
  3. Focus last tab (Google).
  4. Delete the second tab from the last (Yahoo).
  5. Delete the second tab from the last (Bing) without moving mouse pointer.

Then, the 'Google' tab is deleted instead of the 'Bing' one.
I expect to delete 'Bing' tabs.

captured

@Croydon
Copy link
Owner

Croydon commented Apr 6, 2018

Does the error only occur when you DON'T move the mouse pointer?
Meaning, when you close tab 2, move the mouse pointer away from the close button, move the mouse pointer back on the close button from tab 1, click on the close button, the correct tab is getting closed?

@mmktomato
Copy link
Contributor Author

mmktomato commented Apr 6, 2018

Does the error only occur when you DON'T move the mouse pointer?

No. This problem is NOT caused when I move the mouse pointer.

Meaning, when you close tab 2, move the mouse pointer away from the close button, move the mouse > pointer back on the close button from tab 1, click on the close button, the correct tab is getting closed?

Yes.

  1. I move the mouse pointer out from close button.
  2. Get the mouse pointer back on the close button.
  3. Click it.
    Then, the correct tab is closed.

captured2

@mmktomato
Copy link
Contributor Author

mmktomato commented Apr 6, 2018

Oops, mistake. I reopen.

@mmktomato mmktomato reopened this Apr 6, 2018
@mmktomato
Copy link
Contributor Author

Then, this problem happens ONLY when I add many tabs to overflow the tab panel (in other words, scroll bar is shown).

@Croydon
Copy link
Owner

Croydon commented Apr 7, 2018

From a technical point of view this is very, very likely the same layout issue as #106.

Again: if someone has good CSS skills I would appreciate contributions to place the close and mute buttons in a more sophisticated and reliable way.

If I need to do it myself I will need to spend some time to advance my CSS skills and I can't make promises when I can take this time.

@mmktomato
Copy link
Contributor Author

Ok, I understand your situation.

I'd try to fix it when I could take enough time.
But please do not expect because I'm not an expert of CSS 😛

mmktomato added a commit to mmktomato/vertical-tabs-reloaded that referenced this issue Apr 15, 2018
Croydon added a commit that referenced this issue Apr 18, 2018
as a follow up to the fix of #177
@Croydon
Copy link
Owner

Croydon commented Apr 18, 2018

This broke pinned tabs, I will have a look somewhen in the next 48h.

@Croydon Croydon self-assigned this Apr 18, 2018
@Croydon Croydon modified the milestones: until 1.0.0, 0.11.0 Apr 18, 2018
@Croydon
Copy link
Owner

Croydon commented Apr 18, 2018

Turned out that this is an unrelated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants