Add search summary pattern #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes moving the SCSS for search-results into it.
| font-weight: bold; | ||
| } | ||
|
|
||
| .count { |
There was a problem hiding this comment.
Could this be .search-summary-count to match our naming conventions?
There was a problem hiding this comment.
Good point, fixed in edef4c1
quis
added a commit
that referenced
this pull request
May 12, 2015
Turns out that #65 was a breaking change because it rearranged the file structure. I propose bumping the version to 3.0.0 and withdrawing 2.1.0.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention should be for the summary to always start with 'Count services found in lot' and for the rest of the sentence to comprise of the filters applied, each with their own preposition and conjunctions.
For example, the following consists of the following filter sentences:
For filter options of more than 2, the conjunction listed would only feature at the end with all other options joined by commas.