Don't let elements that follow questions float #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a question contains floated elements then there is a risk that the following elements will float in an undesirable way. This change prevents that. It also adds some spacing between questions to give them a bit more breathing room.
quis
force-pushed
the
fix-floating-questions
branch
from
627c3e7 to
ecde070
Compare
|
Could we use |
Use of overflow: hidden could trip us up later
tombye
added a commit
that referenced
this pull request
May 1, 2015
Don't let elements that follow questions float
quis
added a commit
that referenced
this pull request
May 1, 2015
Includes: - #62 Don't let elements that follow questions float
Merged
quis
added a commit
to Crown-Commercial-Service/digitalmarketplace-admin-frontend
that referenced
this pull request
May 1, 2015
This commit: - Adds Javascript for selection buttons - Brings in the SASS changes from Crown-Commercial-Service/digitalmarketplace-frontend-toolkit#62
quis
added a commit
to Crown-Commercial-Service/digitalmarketplace-admin-frontend
that referenced
this pull request
May 1, 2015
This commit: - Adds Javascript for selection buttons - Brings in the SASS changes from Crown-Commercial-Service/digitalmarketplace-frontend-toolkit#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a question contains floated elements then there is a risk that the following elements will float in an undesirable way. This change prevents that.
It also adds some spacing between questions to give them a bit more breathing room.
Example of the problem: