Use strongly typed errors based on thiserror #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makr11st
reviewed
Aug 27, 2024
davidc6
reviewed
Aug 30, 2024
davidc6
reviewed
Aug 30, 2024
tomaszjonak
force-pushed
the
tjonak/thiserror
branch
from
bb3d657
to
edb9a63
Compare
Dyn<error> is generally discouraged in libraries.
tomaszjonak
force-pushed
the
tjonak/thiserror
branch
from
edb9a63
to
6d08385
Compare
makr11st
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dyn is generally discouraged in libraries.
Reraise of #131 from a branch instead of main in my fork. It's easier to keep fork:main in sync and rebase feature branch as upstream progresses.