-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ BUG ] Invoke-FalconDeploy
incorrect execution order when queued
#375
Comments
Invoke-FalconDeploy
incorrect cmd execution order when queued
Invoke-FalconDeploy
incorrect cmd execution order when queuedInvoke-FalconDeploy
incorrect execution order when queued
Interesting report! Thank you for submitting it. I'll talk with the RTR engineering team and see if I can uncover an effective solution. It also looks like the |
In testing, it appears that PSFalcon is simply too fast for the CrowdStrike APIs. ;) I submitted a queued job using The only solution is to add a delay to |
I've implemented the fix for the next release. Could you try updating Import-Module -Name PSFalcon
$ModulePath = (Show-FalconModule).ModulePath
(Invoke-WebRequest -Uri https://raw.githubusercontent.com/CrowdStrike/psfalcon/d824c1cb1a96a540bfad6d06af4b7652e1d1b8e5/public/psf-real-time-response.ps1 -UseBasicParsing).Content > (Join-Path (Join-Path $ModulePath public) psf-real-time-response.ps1) |
Hey Awesome thanks a lot for the feedback, i didn't expect one so quick, you rock ! It seems a 2 seconds delay is necessary. |
This fix is included in the 2.2.7 release. |
Describe the bug
When using Invoke-FalconDeploy on an offline host, the cmd are queued but sometimes do not execute in correct order when host finally comes online.
To Reproduce
With a offline "hostid":
Invoke-FalconDeploy -Archive "Archive.zip" -Run "runfile.exe" -QueueOffline $true -HostId <hostid>
If the different step command "mkdir","cd","put","runscript" are created with the same timestamp, the order of execution will be incorrect when the host comes online.
Expected behavior
Each queued command for the same host should have a different timestamp in order to predict execution order
Environment (please complete the following information):
Additional context
Below a curated/redacted result of Get-FalconQueue command after the host came online and cmd executed
FalconQueue_20240104T1021017583.csv
Notice that the "cd" command, instead of last in order of execution should have in run in 2nd just after "mkdir" cmd
The text was updated successfully, but these errors were encountered: