Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get this repo working with embroider v3+ #210

Open
ynotdraw opened this issue Jul 11, 2023 · 0 comments · May be fixed by #261
Open

Get this repo working with embroider v3+ #210

ynotdraw opened this issue Jul 11, 2023 · 0 comments · May be fixed by #261

Comments

@ynotdraw
Copy link
Contributor

As part of #200, we are disabling embroider-optimized tests to unblock our work. We started getting the following errors with the embroider-optimized tests with that PR:

test-app:test: [1]   - message: ../node_modules/.pnpm/file+packages+ember-toucan-core_@[email protected]_chhstik6enqihwk47y4lzcbm7a/node_modules/@crowdstrike/ember-toucan-core/dist/components/form/controls/combobox.js: Module not found: Error: @crowdstrike/ember-toucan-core is trying to import from #embroider_compat but that is not one of its explicit dependencies

The suggestion was to attempt to upgrade pnpm and embroider dependencies to the latest as done in #205; however, we still have a few issues with those changes. In particular:

test-app:test: [1] $TMPDIR/embroider/c6249b/node_modules/.pnpm/file+packages+ember-toucan-core_@[email protected]_@[email protected]_@e_tm5lpotvrba5vzg34cuvh2fqxm/node_modules/@crowdstrike/ember-toucan-core/dist/components/form/controls/combobox.js/combobox.js: Unsafe dynamic component: this.Option in $TMPDIR/embroider/c6249b/node_modules/.pnpm/file+packages+ember-toucan-core_@[email protected]_@[email protected]_@e_tm5lpotvrba5vzg34cuvh2fqxm/node_modules/@crowdstrike/ember-toucan-core/dist/components/form/controls/combobox.js

This is because we removed the ensure-safe-component helper as part of that PR.

When adding back the ensure-safe-component helper, we get a new error from #206. You can view the full action log here

test-app:test: [1]   - broccoliBuilderErrorStack: ModuleNotFoundError: Module not found: Error: Can't resolve './helpers/ensure-safe-component' in '/home/runner/work/ember-toucan-core/ember-toucan-core/test-app/node_modules/.embroider/rewritten-app'

Chatting with @simonihmig , it's thought that this issue may be related to embroider-build/embroider#1514, as it sound similar.


The outcome of this issue should be:

  • Resolve any embroider issues as listed above that'll unblock us
  • Upgrade to the latest embroider version(s)
  • Use the embroider strict settings as done here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant