fix: Resolve panic in Decoder.Skip()
with corrupt message
#159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a panic when trying to decode a corrupted message, specifically one where the encoded length of a string field is >2GB.
I also added a new
ParseAnnotatedHex()
function in a newprototest
package. This function can be used to convert a string containing a "commented" hexadecimal representation of an encoded Protobuf message into binary, which is useful for managing test data in a more human-readable form. See the godoc comments on the function for more details.Finally, I updated
.golangci.yml
to resolve some config deprecations, which led to having to update some test code that was now generating linter warnings.Fixes #158