Fix people tab loading in organization profiles

[joanagmaia]

Changes proposed ✍️

What

copilot:summary
​
copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

• Label appropriately with Feature, Improvement, or Bug.
• Add screenshots to the PR description for relevant FE changes
• New backend functionality has been unit-tested.
• API documentation has been updated (if necessary) (see docs on API documentation).
• Quality standards are met.

Summary by CodeRabbit

• New Features

  • Contributors are now loaded immediately upon component mount, enhancing data retrieval.

• Bug Fixes

  • Improved error handling ensures the UI accurately reflects data absence when member retrieval fails.

• Improvements

  • Sorting and filtering functionalities have been optimized, resetting pagination as needed for a better user experience.

[coderabbitai]

Walkthrough

The changes in the organization-details-contributors.vue component primarily involve modifications to the data fetching and error handling mechanisms. The fetch function is now invoked within the onMounted lifecycle hook, ensuring immediate data retrieval upon component mounting. Additionally, error handling has been enhanced to reset the contributors array and pagination total in case of a failure. The sorting and filtering functionalities remain unchanged, although minor adjustments were made to the filter configuration.

Changes

File	Change Summary
frontend/src/modules/organization/components/details/organization-details-contributors.vue	- fetch() method added. - onMounted updated to call fetch() for immediate data retrieval. - Improved error handling resets contributors and pagination.total on error. - Minor removal of organizations property from filterConfig.

Possibly related PRs

• Add spinner to organization creation in work experiences #2683: The changes in organization-select.vue involve enhancements to the organization creation process, which may relate to the overall organization management functionality in the application, similar to the updates made in organization-details-contributors.vue.
• Improve autocomplete search for organizations #2687: The modifications in organizationRepository.ts and organizationService.ts focus on improving the organization search functionality, which could be relevant to the contributor details being fetched and displayed in organization-details-contributors.vue.

Suggested reviewers

• gaspergrom

🐇 In the meadow, where bunnies play,
Fetching data brightens the day!
With errors handled, no need to fret,
Contributors ready, we won't forget!
Sorting and filtering, all in a row,
Hopping along, watch our progress grow! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

frontend/src/modules/organization/components/details/organization-details-contributors.vue (2)

309-309: Consider sequential data fetching and error coordination

While adding fetch() in onMounted is correct, consider these improvements:

1. Make the calls sequential to avoid potential race conditions
2. Coordinate error handling between both API calls

-onMounted(() => {
-  doGetMembersCount();
-  fetch();
-});
+onMounted(async () => {
+  try {
+    await doGetMembersCount();
+    await fetch();
+  } catch (error) {
+    // Handle errors consistently
+  }
+});

---

309-309: Consider architectural improvements for better maintainability

The component currently handles both data fetching and presentation. Consider these architectural improvements:

1. Extract data fetching logic into a dedicated composable (e.g., useOrganizationContributors)
2. Implement centralized error handling
3. Unify loading state management between member count and contributor fetching

This would improve maintainability, reusability, and testing.

Example structure:

// useOrganizationContributors.ts
export function useOrganizationContributors(organizationId: string) {
  const loading = ref(false);
  const error = ref<Error | null>(null);
  const contributors = ref<Member[]>([]);
  const totalCount = ref(0);

  const fetchData = async () => {
    loading.value = true;
    error.value = null;
    try {
      const [countData, contributorsData] = await Promise.all([
        fetchMemberCount(organizationId),
        fetchMembers(organizationId)
      ]);
      totalCount.value = countData.count;
      contributors.value = contributorsData.rows;
    } catch (err) {
      error.value = err;
      contributors.value = [];
      totalCount.value = 0;
    } finally {
      loading.value = false;
    }
  };

  return {
    loading,
    error,
    contributors,
    totalCount,
    fetchData
  };
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cf36be1 and e0e4cf0.

📒 Files selected for processing (1)

• frontend/src/modules/organization/components/details/organization-details-contributors.vue (1 hunks)

🔇 Additional comments (1)

frontend/src/modules/organization/components/details/organization-details-contributors.vue (1)

309-309: Verify loading behavior across different scenarios

While the changes address the people tab loading issues, please verify the loading behavior in these scenarios:

1. Initial load
2. Filter changes
3. Sort changes
4. Error recovery
5. Network issues