Improve SERP isEnrichable conditions & activity count filter for sources

[epipav]

Changes proposed ✍️

What

copilot:summary
​
copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

• Label appropriately with Feature, Improvement, or Bug.
• Add screenshots to the PR description for relevant FE changes
• New backend functionality has been unit-tested.
• API documentation has been updated (if necessary) (see docs on API documentation).
• Quality standards are met.

Summary by CodeRabbit

• New Features

  • Introduced an activityCount property to enhance member enrichment criteria.
  • Updated enrichment logic to consider activity count for determining enrichability.

• Bug Fixes

  • Improved SQL query to include maximum activity count for each member in enrichment data.

• Documentation

  • Updated interfaces to reflect the addition of the activityCount property in relevant data structures.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce enhancements to the member enrichment process within the EnrichmentServiceSerpApi class. A new condition is added to the isEnrichableBySource method, which now checks for an activityCount in the input data. Corresponding updates are made to the IEnrichmentSourceInput and IEnrichableMember interfaces to include this new property. Additionally, the enrichMember function is modified to incorporate activityCount into the enrichment input. Finally, the SQL query in fetchMembersForEnrichment is updated to include activityCount in its output.

Changes

File	Change Summary
services/apps/premium/members_enrichment_worker/src/sources/serp/service.ts	Updated isEnrichableBySource to check for input.activityCount.
services/apps/premium/members_enrichment_worker/src/types.ts	Added optional property activityCount?: number to IEnrichmentSourceInput.
services/apps/premium/members_enrichment_worker/src/workflows/enrichMember.ts	Modified enrichMember to include activityCount in enrichmentInput, defaulting to 0.
services/libs/data-access-layer/src/old/apps/premium/members_enrichment_worker/index.ts	Updated SQL query in fetchMembersForEnrichment to include MAX("activitySummary".total_count) as "activityCount".
services/libs/types/src/premium/enrichment.ts	Added property activityCount: number to IEnrichableMember.

Possibly related PRs

• Serp linkedin finder enrichment source #2664: The changes in this PR introduce the EnrichmentServiceSerpApi class, which is directly related to the modifications made in the main PR to the EnrichmentServiceSerpApi class, particularly in how it handles member enrichment based on various identifiers.

Suggested reviewers

• sausage-todd

🐰 In the meadow, where bunnies play,
Activity counts brighten the day!
Enrichment grows, with new checks in place,
Data flows smoothly, a joyful embrace.
With each little hop, we gather our cheer,
For members enriched, the future is clear! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.