Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated Asio API #971

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

bugdea1er
Copy link
Contributor

@bugdea1er bugdea1er commented Jan 5, 2025

Remove all uses of deprecated Asio API, like asio::io_service and asio::ip::address::from_string (tested with compilation flag ASIO_NO_DEPRECATED)

This automatically fixes building with newer versions of Boost

Closes #970

include/crow/socket_adaptors.h Outdated Show resolved Hide resolved
include/crow/http_server.h Show resolved Hide resolved
@gittiver
Copy link
Member

gittiver commented Jan 6, 2025

btw, I fixed the codeQL problem, could you rebase onto master to get this change too.

@bugdea1er
Copy link
Contributor Author

btw, I fixed the codeQL problem, could you rebase onto master to get this change too.

Done!

@gittiver gittiver merged commit 27c9ba3 into CrowCpp:master Jan 6, 2025
11 checks passed
@bugdea1er bugdea1er deleted the io-context branch January 6, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crow using boost::asio error : "boost::asio has no member io_service"
2 participants