Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call middleware during upgrade request #763

Merged

Conversation

bruvey37
Copy link
Contributor

The purpose of this branch is to make a call to the middleware when an "Upgrade" request is received.

For example, the middleware cookie parser can be used to retrieve an identification cookie to verify authorizations during the upgrade.

This fix #762

Copy link
Member

@dranikpg dranikpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it is what others would expect because it's a technical "flow" that should be invisible to high-level users 🤷🏻‍♂️

@gittiver
Copy link
Member

I requested a review from the others.

@gittiver gittiver added the bug Something isn't working label Feb 21, 2024
@gittiver
Copy link
Member

gittiver commented Mar 2, 2024

Got no additional feedback, for me it looks good. Will merge it now.

@gittiver gittiver merged commit c47540b into CrowCpp:master Mar 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware is not called in case of HTTP upgrade
3 participants