Skip to content

recieve response without request being another argument in handler #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 3, 2020

Conversation

ayaankhan98
Copy link
Contributor

Linked Issue #47

@The-EDev The-EDev linked an issue Dec 1, 2020 that may be closed by this pull request
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error when running example

terminate called after throwing an instance of 'std::runtime_error'
  what():  no handler for url /add/<int>/<int>
Aborted (core dumped)

@ayaankhan98
Copy link
Contributor Author

Getting this error when running example

terminate called after throwing an instance of 'std::runtime_error'
  what():  no handler for url /add/<int>/<int>
Aborted (core dumped)

@The-EDev fixed

@The-EDev The-EDev self-requested a review December 2, 2020 22:20
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to the other comments, I would be thankful if you could edit line 33 and 34 of docs/guides/routes.md (remove line 34, edit the code part of 33, and add a <br> at the end of 33).

Everything else seems good, thanks for your help.

@ayaankhan98
Copy link
Contributor Author

in addition to the other comments, I would be thankful if you could edit line 33 and 34 of docs/guides/routes.md (remove line 34, edit the code part of 33, and add a <br> at the end of 33).

Everything else seems good, thanks for your help.

Done!

@The-EDev The-EDev merged commit c81a2d8 into CrowCpp:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow handler to use response without request being an argument
3 participants