-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indentation to json dump method #748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at my comment. As a general comment I tend to leave dump and dump internal as it is and put the indentation into a pretty_print function or something like this.
Thank you for the review. Leaving those functions as they are, I should duplicate a bunch of code in |
I don't know if formatting output should be a part of the library. But that's up too you . Code looks ok I guess ;) |
The problem is specified in issue #747 .
This is a simple solution to improve the dump method without breaking any APIs and is fully backward-compatible.