New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minimize the precision loss when dumping double to string #712

Merged

gittiver merged 7 commits into CrowCpp:master from junekhan:bugfix/presion-loss-of-dumping-double

Jan 29, 2024

Contributor

junekhan commented Oct 25, 2023

This PR fixes #711


          fix: minimize the precision loss when dumping double to string

6130f2e

gittiver reviewed

View reviewed changes

include/crow/json.h Outdated Show resolved Hide resolved

gittiver reviewed

View reviewed changes

include/crow/json.h Outdated Show resolved Hide resolved


          fix: abandon one-time macro

8bb7cf1

gittiver reviewed

View reviewed changes

include/crow/json.h Outdated Show resolved Hide resolved

gittiver reviewed

View reviewed changes

include/crow/json.h Outdated Show resolved Hide resolved

gittiver requested changes

View reviewed changes

Member

gittiver left a comment

see comments

gittiver linked an issue

that may be closed by this pull request

The Decimal Digit Problem of Double Type in wvalue #703

Closed


          fix: replace hard-coded buffer size, replace sprintf with snprintf

543fa7a

gittiver reviewed

View reviewed changes

include/crow/json.h Outdated Show resolved Hide resolved


          fix: replace DECIMAL_DIG with DBL_DECIMAL_DIG

f1894c5

gittiver reviewed

View reviewed changes

include/crow/json.h Outdated Show resolved Hide resolved

gittiver added 2 commits

January 23, 2024 12:47


          Update json.h changed to C++11 DECIMAL_DIGIT

75d7811


          added cfloat include

69b17cc

Member

gittiver commented Jan 23, 2024

a unit test on the template tests fails - it expect exact values not something with epsilon.
Needs to be adressed before merging the PR.

gittiver requested changes

View reviewed changes

Member

gittiver left a comment

Unittest template_tests fails.

This comment was marked as duplicate.

Sign in to view


          fix: identify float and double as different numeral types, and approa…

5ba4b39

…ch their precisions accordingly

Contributor Author

junekhan commented Jan 24, 2024 •

edited

Loading

a unit test on the template tests fails - it expect exact values not something with epsilon. Needs to be adressed before merging the PR.

Yes, I've made a patch for that, and the scope becomes much bigger. Please have a careful check to help me ensure the changes. BTW, some of the unit tests cannot run properly on my machine, so I have to resort to this github action. Thanks.

gittiver approved these changes

View reviewed changes

gittiver merged commit 973d5fa into CrowCpp:master

6 checks passed

gittiver added a commit that referenced this pull request


          Merge branch 'master' into v1.1

ae87100

* master:
  fix: call after_handlers for legitimate requests without body part
  Handle _CROW_ILL or _CROW_ICD being NOTFOUND
  small explanations in the example on using CORS middleware in Crow v1.0
  Use const std::string& as argument to route() (#684)
  fix: minimize the precision loss when dumping double to string (#712)
  package format changed to zip, version set to >1.1.0 (first release)
  Fix #754 (#755)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet