Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #include for example_with_all. #63

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Fix #include for example_with_all. #63

merged 3 commits into from
Nov 18, 2020

Conversation

supersaiyanmode
Copy link
Contributor

Using relative directories like "../build/crow_all.h" might not work in all settings.

The-EDev
The-EDev approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help, I'll merge this once the tests are passed.

@The-EDev The-EDev merged commit 48c12f5 into CrowCpp:master Nov 18, 2020
@madduci
Copy link
Contributor

madduci commented Jan 5, 2021 •
edited
Loading

I've found out that building a recipe with conan triggers an error using the relative path like "../build/crow_all.h" in the released version "v0.2"

@madduci madduci mentioned this pull request Jan 5, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-EDev The-EDev The-EDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supersaiyanmode @madduci @The-EDev