New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge_all.py #518

Merged

dranikpg merged 1 commit into CrowCpp:master from deroskarmodulo:master

Aug 15, 2022

Contributor

deroskarmodulo commented Aug 12, 2022

On Windows merge_all.py results in an encoding error. Adding encoding='UTF-8' in open() file function resolves this issue.


          add utf-8 encoding for file opening

dranikpg approved these changes

View reviewed changes

Member

dranikpg left a comment

Thanks for the fix!

This actually left me questioning where crows sources have non-ascii characters 🤔 Turns out the only ones are └➝ arrows for debug printing

dranikpg merged commit df0b50b into CrowCpp:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet