Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template/typename keywords to crow macros #508

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Add template/typename keywords to crow macros #508

merged 1 commit into from
Jul 24, 2022

Conversation

dranikpg
Copy link
Member

Fixes for #369

See #369 (comment) for explanations

The-EDev
The-EDev approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! The tests seem to be passing which means that there isn't any issue with websocket rules being created. There are also no related warnings in the CI log. Merging now.

@The-EDev The-EDev merged commit 04808b8 into CrowCpp:master Jul 24, 2022
@dranikpg
Copy link
Member Author

that there isn't any issue with websocket rules being created

Yes, because I didn't touch any of the websocket stuff 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-EDev The-EDev The-EDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dranikpg @The-EDev