Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: Could not define route for HEAD method #491

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Fixed bug: Could not define route for HEAD method #491

merged 2 commits into from
Jul 1, 2022

Conversation

erikaldsund
Copy link
Contributor

Defining a HEAD method would give HTTP error code 405 (Method Not Allowed) and
calling OPTIONS on the route would return HEAD twice in the Allow header.

Defining a HEAD method would give HTTP error code 405 (Method Not Allowed) and
calling OPTIONS on the route would return HEAD twice in the Allow header.
@The-EDev
Copy link
Member

Tests are passing, it's just that coveralls is down for maintenance.

Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be alright, I'll update the documentation to mention this change soon. Thanks for your help!

@The-EDev The-EDev merged commit fc4ad28 into CrowCpp:master Jul 1, 2022
@erikaldsund erikaldsund deleted the head_route_fix branch July 1, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants