Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpage tutorial #451

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Webpage tutorial #451

merged 6 commits into from
Jun 10, 2022

Conversation

The-EDev
Copy link
Member

@The-EDev The-EDev commented Jun 3, 2022

This PR adds a tutorial for how to return webpages using Crow, and the very basics of context and mustache templating.

It also fixes an issue I encountered where the privacy policy link isn't centered in pages that aren't home.

it also also removed the python examples since they're not relevant to Crow (the basic example is just a comparison between Crow and flask, which isn't needed. And the test example is redundant since Crow has its own C++ tests).

Copy link
Collaborator

@luca-schlecker luca-schlecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check if the resulting doc resolves the centering problem.

docs/getting_started/a_simple_webpage.md Outdated Show resolved Hide resolved
docs/getting_started/a_simple_webpage.md Outdated Show resolved Hide resolved
docs/getting_started/a_simple_webpage.md Show resolved Hide resolved
docs/getting_started/a_simple_webpage.md Outdated Show resolved Hide resolved
docs/getting_started/your_first_application.md Outdated Show resolved Hide resolved
@The-EDev The-EDev merged commit 53a2921 into master Jun 10, 2022
@The-EDev The-EDev deleted the webpage_tutorial branch June 10, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants