Cookieparser attributes

[dranikpg]

Crows cookie_parser currently doesn't support setting any attributes on cookies (most importantly expires and path). I've added support for all available HTTP cookie attributes.

This helps #406

Cookie parsers context allows now to set attributes in a builder style:

auto& cookie_ctx = app.get_context<crow::CookieParser>(req);
cookie_ctx.set_cookie("key", "value")
    .max_age(60)
    .path("/")
    .secure();

I've chosen boost for timepoints and durations as Crow already depends on it and std::time_t/std::tm are just horribly difficult to use.

[The-EDev]

I haven't looked too deeply into the code but have you considered std::chrono or is it not applicable here?

[dranikpg]

have you considered std::chrono?

I didn't want to resort to 3rd party libraries initially so I looked at all of std (up to c++ 11/14)

chrono

Chrono is more for tracking time than working with dates. Most of its features on the docs were added in c++20 when it was refreshed to support dates properly. Chronos timepoint is the only 11/14 struct to hold a datetime and it doesnt support any operations on it. The duration type is bound to a clock.

c-style

Date operations in chrono are possible with a group of c-style functions and helper structs: std::tm, std::time_t, mktime. Like even creating a date. Those are really inconvenient and hard to use. At least they support put_time and get_time for reading/writing them (and thats all the cookieparser needs).

---

As a whole, std::tm is convertible from both chrono and boost and is the universal c++ way to store daytime. We could really strip boost out and use only it. It'd be probably the best way as of a second thought. Potential users just should be aware to use boost time for creating/managing dates themselves (or chrono with c++20).

[The-EDev]

In addition to the comments, it might be useful to create some documentation on how to use this middleware. (I can do that, you don't have to do it if you don't want to)

Thanks a lot for the work you've done here!

[dranikpg]

I've added an example for the cookie parser, as there previously weren't any.
As for the docs, I'd maybe suggest maintaining one page for all small additional middleware (cors, cookies) instead of having separate tiny pages for them all. This would make it easier to navigate around

[The-EDev]

I apologize, I just now got around to looking at the documentation. Aside from the comments, mkdocs.yml needs to be changed as follows for the new guide to be built:

@@ -55,7 +55,7 @@ nav:
             - Writing Tests: guides/testing.md
         - Using Crow:
             - HTTP Authorization: guides/auth.md
-            - CORS Setup: guides/CORS.md
+            - Included Middlewares: guides/included-middleware.md
         - Server setup:
             - Proxies: guides/proxies.md
             - Systemd run on startup: guides/syste.md

Aside from that everything seems to be in order :)

[The-EDev]

Everything seems to be in order.

Thank you very much for your work!