Added unsafe load functions (allows absolute file for special cases)

[zefrenchy]

as per #336

[crow-clang-format]

--- include/crow/http_response.h	(before formatting)
+++ include/crow/http_response.h	(after formatting)
@@ -220,7 +220,7 @@
             utility::sanitize_filename(path);
             set_static_file_info_unsafe(path);
         }
-        
+
         ///Return a static file as the response body without sanitising the path (use set_static_file_info instead)
         void set_static_file_info_unsafe(std::string path)
         {
--- include/crow/mustache.h	(before formatting)
+++ include/crow/mustache.h	(after formatting)
@@ -636,7 +636,7 @@
             utility::sanitize_filename(filename_sanitized);
             return detail::get_loader_ref()(filename_sanitized);
         }
-        
+
         inline std::string load_text_unsafe(const std::string& filename)
         {
             return detail::get_loader_ref()(filename);
@@ -648,7 +648,7 @@
             utility::sanitize_filename(filename_sanitized);
             return compile(detail::get_loader_ref()(filename_sanitized));
         }
-        
+
         inline template_t load_unsafe(const std::string& filename)
         {
             return compile(detail::get_loader_ref()(filename));

[The-EDev]

Aside from clang-format and my other comment. I think it might be best if you force push your changes. Since the previously closed PR's code is still there.

[crow-clang-format]

--- include/crow/http_response.h	(before formatting)
+++ include/crow/http_response.h	(after formatting)
@@ -220,7 +220,7 @@
             utility::sanitize_filename(path);
             set_static_file_info_unsafe(path);
         }
-        
+
         /// Return a static file as the response body without sanitizing the path (use set_static_file_info instead)
         void set_static_file_info_unsafe(std::string path)
         {
--- include/crow/mustache.h	(before formatting)
+++ include/crow/mustache.h	(after formatting)
@@ -636,7 +636,7 @@
             utility::sanitize_filename(filename_sanitized);
             return detail::get_loader_ref()(filename_sanitized);
         }
-        
+
         inline std::string load_text_unsafe(const std::string& filename)
         {
             return detail::get_loader_ref()(filename);
@@ -648,7 +648,7 @@
             utility::sanitize_filename(filename_sanitized);
             return compile(detail::get_loader_ref()(filename_sanitized));
         }
-        
+
         inline template_t load_unsafe(const std::string& filename)
         {
             return compile(detail::get_loader_ref()(filename));

[zefrenchy]

Looks good to me.

[zefrenchy]

completely new to the GitHub workflow ... in case it's not painfully obvious 😅

[crow-clang-format]

--- include/crow/http_response.h	(before formatting)
+++ include/crow/http_response.h	(after formatting)
@@ -220,7 +220,7 @@
             utility::sanitize_filename(path);
             set_static_file_info_unsafe(path);
         }
-        
+
         /// Return a static file as the response body without sanitizing the path (use set_static_file_info instead)
         void set_static_file_info_unsafe(std::string path)
         {
--- include/crow/mustache.h	(before formatting)
+++ include/crow/mustache.h	(after formatting)
@@ -636,7 +636,7 @@
             utility::sanitize_filename(filename_sanitized);
             return detail::get_loader_ref()(filename_sanitized);
         }
-        
+
         inline std::string load_text_unsafe(const std::string& filename)
         {
             return detail::get_loader_ref()(filename);
@@ -648,7 +648,7 @@
             utility::sanitize_filename(filename_sanitized);
             return compile(detail::get_loader_ref()(filename_sanitized));
         }
-        
+
         inline template_t load_unsafe(const std::string& filename)
         {
             return compile(detail::get_loader_ref()(filename));

[The-EDev]

clang-format is complaining about these spaces being in the text, as it requires that any empty lines have no tabs or spaces.

As for force pushing, I don't know what you're using to manage git, but in the terminal you would:

1. git reset --soft <commit> with <commit> being the commit right before any of your changes in this PR. (make sure you already have all the changes from github already in your local repo, you can run git pull to make sure before you start this process)
2. git commit -m "my new commit message" (make sure your files are marked as "to be committed, you can do that by running git status after step 1")
3. git push -f
   This will remove all the old commits in your git branch (and this PR) and put all your changes in the commit you made in step2 instead.

[zefrenchy]

Thanks for the workflow pointers.

[zefrenchy]

argh so sorry .. I'm not helping much am I?

[The-EDev]

don't go hard on yourself, it's just a merge conflict, I can handle it if you'd like

[zefrenchy]

You're right ... I give up! take over. I'll try to do better next time if I ever have the chance.

[zefrenchy]

no idea where those file perm changes came from ... I blame my NAS

[The-EDev]

don't worry about it, I'm glad you're helping this project forward :)

[The-EDev]

Looks good, Will merge once tests are done

[zefrenchy]

Success! I feel validated 😅