Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format #286

Merged
merged 9 commits into from
Nov 27, 2021
Merged

clang-format #286

merged 9 commits into from
Nov 27, 2021

Conversation

The-EDev
Copy link
Member

created clang-format rules close to the original project's, reformatted the project, and added a bot to enforce the rules in PRs through status checks and comments.

@The-EDev The-EDev marked this pull request as draft November 25, 2021 11:54
@luca-schlecker
Copy link
Collaborator

I am having errors with VSCode's Cpp-Tools extension which I use to format my code based on a code style or a .cang-format file.
It has a problem with the following statement:

SpacesInLineCommentPrefix:
    Minimum: 1
    Maximum: -1

leading to this message:

error: unknown key 'SpacesInLineCommentPrefix'
  SpacesInLineCommentPrefix: 
  ^~~~~~~~~~~~~~~~~~~~~~~~~
  Error reading Crow\.clang-format: invalid argument

Removing it solves the issues.

@The-EDev
Copy link
Member Author

I put that in there for forwards compatibility with clang-format 14. I'll comment it out for now.

@The-EDev The-EDev marked this pull request as ready for review November 27, 2021 14:39
luca-schlecker
luca-schlecker previously approved these changes Nov 27, 2021
Copy link
Collaborator

@luca-schlecker luca-schlecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now. I've also checked if every file is correctly formatted: Seems good. 🚀

@luca-schlecker luca-schlecker merged commit 081f869 into master Nov 27, 2021
@luca-schlecker luca-schlecker deleted the clang-format branch November 27, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants