Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only GET on HTTP/0.9 #262

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Use only GET on HTTP/0.9 #262

merged 4 commits into from
Nov 2, 2021

Conversation

The-EDev
Copy link
Member

@The-EDev The-EDev commented Nov 1, 2021

Might need some more testing (primarily because looking at the parser the wrong way seems to break it)

closes #248

Earlier behavior only checked whether every byte was parsed, which isn't
ideal

Signed-off-by: The-EDev <[email protected]>
mrozigor
mrozigor previously approved these changes Nov 1, 2021
@The-EDev
Copy link
Member Author

The-EDev commented Nov 1, 2021

Tests are failing, multi_server is blocking everything else for some reason..

Copy link
Collaborator

@luca-schlecker luca-schlecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine and the tests pass. 👍

@The-EDev The-EDev merged commit e48e1fa into master Nov 2, 2021
@The-EDev The-EDev deleted the http09_get_only branch November 2, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crow doesn't reject incorrect HTTP/0.9 requests
3 participants