Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced release.py with release.sh #252

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Replaced release.py with release.sh #252

merged 3 commits into from
Oct 27, 2021

Conversation

The-EDev
Copy link
Member

I made this change because the python script for the most part only executed system commands.
I also fixed a bug in the script where v5.13 (for example) would be parsed as v5.1

I managed to keep the colored output and everything :)

This is because the python script for the most part only executed system commands
I also fixed a bug in the script where v5.13 (for example) would be parsed as v5.1
scripts/release.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@luca-schlecker luca-schlecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like everything works, but I could only clone using https and not ssh and my final PKGBUILD contained CRLF but that must be because I am on windows. (using WSL)

scripts/release.sh Outdated Show resolved Hide resolved
@The-EDev
Copy link
Member Author

The thing is that updating the AUR package requires submitting via git through ssh, so there's no real way around it..

@The-EDev The-EDev merged commit ea64dfa into master Oct 27, 2021
@The-EDev The-EDev deleted the release.sh branch October 27, 2021 08:47
@luca-schlecker
Copy link
Collaborator

luca-schlecker commented Oct 27, 2021

I guess it is here to stay. It shouldn't matter, as long as it works. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants