-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Crow compile on MacOS #242
Conversation
also snuck in some guide updates
Is there a way to reproduce #229 on Linux or Windows or is it a problem with the Apple C++ Standard Library? Edit: Seems like there is no way. It looks like it's specifically a problem with the C++ standard library for Apple. |
It seems to be related to Apple's standard library, since it's a compiler error that doesn't occur on Linux or Windows. We could add a macro specifically to check whether MacOS is being used and change the code based on that, I think that might be a better approach than creating new values. |
I think including that
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I didn't test it, as I don't have an osx device. 🎉
Just tested on my MacOS machine, works like a charm. Merging now. |
Needs some testing (primarily creating a blueprint with a custom static directory)
I'm also not sure if this is the right way to do things, I mainly changed things until the code compiled.
fixes #229