Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped setup #228

Merged
merged 37 commits into from
Oct 5, 2021
Merged

Revamped setup #228

merged 37 commits into from
Oct 5, 2021

Conversation

The-EDev
Copy link
Member

@The-EDev The-EDev commented Sep 29, 2021 •
edited
Loading

I'm pretty sure this is the biggest PR ever submitted to Crow, in all aspects.

A Huge Thank You to @luca-schlecker for pretty much making this PR. And making everything I built on top possible. Absolutely none of these features would be here without your hard work and expertise. Your help is invaluable!
Also Thanks to @Leon0402 for helping out with CMake submodule support

Changes

  • FetchContent support.
  • A proper CMake target (Linking to Crow::Crow).
  • FindPackage support.
  • Almost all examples on machines compiling with MSVC .
  • Submodule support.
  • Optional installation step.
  • Removed tcmalloc from cmake and documentation.
  • Amalgamate, Compression, and SSL are all now part of CMake, latter two do not require definition inside the source file anymore. not enabling them will not build their tests/examples.
  • Completely overhauled release script, now changes all code, creates 3 different packages (deb, aur, and standalone tar).
  • Removed installing crow_all.h in favor of multiple headers and crow.h.
  • Updated deb metadata.
  • Clarified license.
  • Improved visibility on gitter badge.
  • Tests now use Debug (no optimization) builds (Improves code coverage by 2% and gives correct line reports).
  • Added separate documentation for Linux, MacOS, and Windows Crow setup (old doc remains as Legacy, will be removed after next release).
  • Added 404 and 405 error explanation for catchall route docs.
  • Added analytics via matomo (analytics hosted on my personal site), also added privacy policy page with link in footer).
  • Updated code colors to match light theme.
  • Added display for Crow's financial supporters on OpenCollective.
  • Fixed Sidebar issue on narrow screens.
  • Fixed Get crow Icons being misaligned.
  • CROW_ENABLE_SSL doesn't disable non-SSL code anymore (reverts Disable non SSL code on SSL macro #206).
  • SSL Tests added (added ssl testing #130).
  • Fixed issue where cpp-coveralls wasn't compatible with newer GCOV versions.
  • Fixed issue where PR coverage would affect master coverage results

Shortcomings

  • CMake tutorials aren't as good as I would like them to be (Especially on Windows and MacOS)
  • New cpp-coveralls not tested on drone.io Test ran, seems like it succeeded.
  • I didn't add all the other tutorials, primarily due to this PR becoming too big and them being off topic anyway
  • I forgot to add -DCROW_AMALGAMATE=ON to .travis.yml

Closes #160 #219 #214

The-EDev and others added 29 commits April 17, 2021 02:33
@The-EDev
added initial ssl testing
798f190
@The-EDev
fixed small issues
3aa13bc
@The-EDev
added development package for openssl
ef0ed8c
@The-EDev
Merge branch 'master' into ssl_test
84878ae
@luca-schlecker
Revert "defining CROW_ENABLE_SSL disables non SSL code"
21c872e 
This reverts commit 10f3238.
@luca-schlecker
enable compression after first use of 'use_compression'.
3c9e5d1
@luca-schlecker
rework cmake configs.
28acb2c 
See #160 for more info.
@luca-schlecker
fix basic and blueprint example not building on some machines.
f90f9b8
@luca-schlecker
add find_package support.
fda2cdd
@luca-schlecker
disable compression test if configured without enabling compression s…
989ae6a 
…upport.
@luca-schlecker
inform about not executed tests if ssl or compression aren't enabled.
4c5b8d3
@The-EDev
Merge pull request #209 from luca-schlecker/main
300e5bf 
rework cmake configs
@luca-schlecker
set the default value for building the examples, building the tests a…
042fa06 
…nd installing Crow based on Crow being the top-level project.
@The-EDev
Merge pull request #218 from luca-schlecker/main
3972cd3 
Friendlier FetchContent and add_subdirectory support.
@The-EDev
Updated release script such that all you need to do is run the script…
ab27164 
… and make a couple of commits to have a full release.
@The-EDev
removed temporary lines from PKGBUILD
105b90c
@The-EDev
corrected package script for PKGBUILD
98705cf
@The-EDev
made SSL test work
f5c392a
@The-EDev
Compile tests in debug mode (no optimization)
5ceb5f5 
This helps make coverage more consistent, and should make any future problems easier to find
@The-EDev
Merge remote-tracking branch 'refs/remotes/origin/revamped_setup'
b3638a3 
Conflicts:
	.drone.yml
@The-EDev
Updated ssl_test CMake config to match revamped_setup
ac36da8
@The-EDev
updated ssl test to only be added to CMake if CROW_ENABLE_SSL is on
3b61ce9
@The-EDev
Merge pull request #130 from CrowCpp/ssl_test
53d746e 
added ssl testing
@The-EDev
fixed a problem with compiling example_with_all and added CROW_AMALGA…
736bc4f 
…MATE to drone options
@The-EDev
Updated .drone.yml to use modified cpp-coveralls (NOT TESTED, Drone n…
3b34877 
…eeds to be run to make sure everything works)
@The-EDev
Further clarified BSD license and logo copyright
e922a8c
@The-EDev
made gitter badge in README slightly more readable
62897ac
@The-EDev
Added updated setup instructions (kept old instructions as "legacy")
db18647
@The-EDev
Updated site:
278540e 
Added analytics via matomo (analytics hosted on my personal site), also added privacy policy page with link in footer
Updated code colors to match light theme
Added display for Crow's financial supporters on OpenCollective
Fixed Sidebar issue on narrow screens
Fixed Get crow Icons being misaligned
@The-EDev The-EDev requested a review from mrozigor September 29, 2021 23:26
This was linked to issues Sep 29, 2021
Better docs readability #214
Closed
CrowCpp Sidebar broken #219
Closed
luca-schlecker
luca-schlecker reviewed Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@luca-schlecker luca-schlecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good otherwise. 👍

docs/getting_started/setup/linux.md Outdated Show resolved Hide resolved
docs/getting_started/setup/windows.md Show resolved Hide resolved
scripts/PKGBUILD Show resolved Hide resolved
The-EDev and others added 6 commits September 30, 2021 13:27
@The-EDev
corrected AUR instructions
56b6449
@The-EDev
added fix for PR coverage affecting master coverage
a22c5da 
This fix relies on the new changes added to CrowCpp/cpp-coveralls in 8b427c04a691867bb29a0acfc2d948a690476d79
@luca-schlecker
Don't enforce the set of features crow was installed with but instead…
258e0f5 
… give the ability to freely choose them, even after it was installed.
@The-EDev
Merge pull request #231 from luca-schlecker/revamped_setup
6c7bb5a 
Selecting features after installation
@The-EDev
Merge branch 'master' into revamped_setup
de9e860
@The-EDev
Merge branch 'master' into revamped_setup
72e33c7
@The-EDev
Copy link
Member Author

The-EDev commented Oct 2, 2021

Looks like this PR is now fully ready to be merged. @mrozigor would you like to review it before I merge? @luca-schlecker and I went over it already.

@mrozigor
Copy link
Member

mrozigor commented Oct 4, 2021 •
edited
Loading

Yep - I will try to make review tomorrow.

@The-EDev The-EDev merged commit 41468b0 into master Oct 5, 2021
@The-EDev The-EDev deleted the revamped_setup branch October 5, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-schlecker luca-schlecker luca-schlecker left review comments

@mrozigor mrozigor mrozigor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CrowCpp Sidebar broken Better docs readability Installing Crow
4 participants
@The-EDev @mrozigor @autoantwort @luca-schlecker