Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License editing #155

Closed
wants to merge 5 commits into from
Closed

License editing #155

wants to merge 5 commits into from

Conversation

The-EDev
Copy link
Member

This PR adds CrowCpp to Corw's license. It also enforces this license by including it in source files.

I also made it so that the notice is only included once when all header files are merged.

This PR contributes to #143

@The-EDev The-EDev requested a review from mrozigor June 28, 2021 09:54
@mrozigor
Copy link
Member

Hmm, is this necessary? Personally I don't like license header in each file. Isn't LICENSE file enough?

@The-EDev
Copy link
Member Author

Hmmm, for the git repo I'm guessing it isn't. But I believe crow_all.h would be considered a redistribution of the source code. so putting it at the top of crow_all.h along with the LICENSE file would probably be enough.

@The-EDev
Copy link
Member Author

Closing this in favor of just incorporating the license in crow_all.h only

@The-EDev The-EDev closed this Jun 29, 2021
@The-EDev The-EDev mentioned this pull request Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants