HEAD and OPTIONS handling
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved body handling to Response.end() and fixed a bug where a 404 was not returned on a route that doesn't exist
The reason for removing it was an issue with Curl rather than how HEAD should be handled.
mrozigor
reviewed
Apr 3, 2021
mrozigor
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for crow to automatically handle
HEADandOPTIONSmethods.HEADreturns the same result as get, except the body is missing.OPTIONSreturns a 204 response with an Allow header containing all the methods the specific route can use (or all the methods the server can use if the url ishttp://myserver.etc/*).closes #26