Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_CROW_ICD-NOTFOUND #661

Closed
Rxann opened this issue Jun 15, 2023 · 3 comments · Fixed by #720
Closed

_CROW_ICD-NOTFOUND #661

Rxann opened this issue Jun 15, 2023 · 3 comments · Fixed by #720
Labels
bug Something isn't working

Comments

@Rxann
Copy link

Rxann commented Jun 15, 2023

At the top of my visual studio cmake project, this is present. the error is C++ command-line error: invalid macro definition: _CROW_ICD-NOTFOUND. Any help would be appreciated.

@gittiver
Copy link
Member

I found this in build directory, CrowConfig.cmake:
get_target_property(_CROW_ICD Crow::Crow INTERFACE_COMPILE_DEFINITIONS)

its produced by cmake/CrowConfig.cmake.in

How did you build your Visual Studio Project, using cmake?
It would be interesting to see the results of the cmake configure step (cmake -B ...).

@The-EDev The-EDev added the bug Something isn't working label Jun 16, 2023
hlmodi added a commit to hlmodi/Crow that referenced this issue Jul 7, 2023
@SpriteOvO
Copy link

Same problem. Using Crow from vcpkg on Windows with MSVC.

  1. vcpkg install crow:x64-windows-static
  2. CMakeLists.txt

    find_package(Crow CONFIG REQUIRED)
    target_link_libraries(my-target PRIVATE Crow::Crow)
  3. cmake -B build -S . -DCMAKE_TOOLCHAIN_FILE=path/to/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows-static
    cmake --build build --config RelWithDebInfo
  4. See error command line : warning C5102: ignoring invalid command-line macro definition '_CROW_ICD-NOTFOUND'

@SpriteOvO
Copy link

Workaround

# Workaround https://github.com/CrowCpp/Crow/issues/661
list(REMOVE_ITEM _CROW_ICD "_CROW_ICD-NOTFOUND")
set_target_properties(Crow::Crow PROPERTIES INTERFACE_COMPILE_DEFINITIONS "${_CROW_ICD}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants