Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coveralls does not compare PR coverage to master #184

Closed
The-EDev opened this issue Aug 1, 2021 · 0 comments · Fixed by #198
Closed

Coveralls does not compare PR coverage to master #184

The-EDev opened this issue Aug 1, 2021 · 0 comments · Fixed by #198
Labels
bug Something isn't working

Comments

@The-EDev
Copy link
Member

The-EDev commented Aug 1, 2021

The problem here is the branch parameter i set instead of using master, this is making PRs compare against themselves instead of master. IIRC this was a fix to coveralls not showing up at all
@The-EDev The-EDev added the bug Something isn't working label Aug 1, 2021
The-EDev added a commit that referenced this issue Aug 13, 2021
@The-EDev
this would theoratically fix the bug in #184, but I'm not 100% sure i…
6812d80 
…t will..
@The-EDev The-EDev mentioned this issue Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix coveralls branch CrowCpp/Crow
1 participant
@The-EDev