utility: improve string_equals function.

Return early if inequality is found.
CrowCpp · Jun 7, 2022 · cb65082 · cb65082
1 parent f5f8fd8
commit cb65082
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/include/crow/utility.h b/include/crow/utility.h
@@ -788,20 +788,24 @@ namespace crow
          */
         inline static bool string_equals(const std::string& l, const std::string& r, bool case_sensitive = false)
         {
-            bool equal = true;
-
             if (l.length() != r.length())
                 return false;
 
             for (size_t i = 0; i < l.length(); i++)
             {
                 if (case_sensitive)
-                    equal &= (l[i] == r[i]);
+                {
+                    if (l[i] != r[i])
+                        return false;
+                }
                 else
-                    equal &= (std::toupper(l[i]) == std::toupper(r[i]));
+                {
+                    if (std::toupper(l[i]) != std::toupper(r[i]))
+                        return false;
+                }
             }
 
-            return equal;
+            return true;
         }
 
         template<typename T, typename U>