Fixed issue where an index in qs_parse is incorrectly incremented bey…

…ond the maximum possible value
CrowCpp · Jun 27, 2022 · 79eec91 · 79eec91
1 parent 75c522f
commit 79eec91
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/include/crow/query_string.h b/include/crow/query_string.h
@@ -119,11 +119,10 @@ inline int qs_parse(char* qs, char* qs_kv[], int qs_kv_size, bool parse_url = tr
     {
         qs_kv[i] = substr_ptr;
         j = strcspn(substr_ptr, "&");
-        if ( substr_ptr[j] == '\0' ) {  break;  }
+        if ( substr_ptr[j] == '\0' ) { i++; break;  } // x &'s -> means x iterations of this loop -> means *x+1* k/v pairs
         substr_ptr += j + 1;
         i++;
     }
-    i++;  // x &'s -> means x iterations of this loop -> means *x+1* k/v pairs
 
     // we only decode the values in place, the keys could have '='s in them
     // which will hose our ability to distinguish keys from values later