Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Issue 1360 #16

Merged
merged 8 commits into from
Jan 4, 2021
Merged

PR: Issue 1360 #16

merged 8 commits into from
Jan 4, 2021

Conversation

bhall-ctre
Copy link
Contributor

@bhall-ctre bhall-ctre commented Dec 21, 2020 •
edited
Loading

This branch

  1. fixes some numbered lists in the README
  2. updates the readme to match our fix for Unable to run example unless "c_SetPhoenixDiagnosticsStartTime(-1);" is commented out. #15
  3. solves Unable to run example unless "c_SetPhoenixDiagnosticsStartTime(-1);" is commented out. #15 by running diagnostics through the user program
  4. changes the README not to have the user install the diag server through Phoenix Tuner
  5. changes the README to have the user run their program prior to using Phoenix Tuner

@JCaporuscio JCaporuscio merged commit 838cc8e into CrossTheRoadElec:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhall-ctre @JCaporuscio