Skip to content

Repository navigation

Banners en homepage y su gestión por admins - #165

Merged
leoAchu16 merged 2 commits into
devfrom
OM-523
May 21, 2026
Merged

Banners en homepage y su gestión por admins#165
leoAchu16 merged 2 commits into
devfrom
OM-523

Correcciones de CodeRabbit

d063949
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 21, 2026 in 1m 39s

Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 7 in prisma/migrations/20260521004958_add_banners/migration.sql

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use VARCHAR2 instead of VARCHAR. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5IMmnaOoPJ8sHDDU0J&open=AZ5IMmnaOoPJ8sHDDU0J&pullRequest=165

Check warning on line 171 in src/modules/admin/banners/admin-banners.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Object.hasOwn()' instead of 'Object.prototype.hasOwnProperty.call()'. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5IMmnNOoPJ8sHDDU0F&open=AZ5IMmnNOoPJ8sHDDU0F&pullRequest=165

Check warning on line 6 in prisma/migrations/20260521004958_add_banners/migration.sql

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use VARCHAR2 instead of VARCHAR. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5IMmnaOoPJ8sHDDU0I&open=AZ5IMmnaOoPJ8sHDDU0I&pullRequest=165

Check warning on line 172 in src/modules/admin/banners/admin-banners.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Object.hasOwn()' instead of 'Object.prototype.hasOwnProperty.call()'. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5IMmnNOoPJ8sHDDU0G&open=AZ5IMmnNOoPJ8sHDDU0G&pullRequest=165

Check warning on line 4 in prisma/migrations/20260521004958_add_banners/migration.sql

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use VARCHAR2 instead of VARCHAR. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5IMmnaOoPJ8sHDDU0H&open=AZ5IMmnaOoPJ8sHDDU0H&pullRequest=165

Check warning on line 135 in src/modules/admin/banners/admin-banners.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Math.max()` to simplify ternary expressions. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5K6aU6SMXNKUU1ffJK&open=AZ5K6aU6SMXNKUU1ffJK&pullRequest=165

Check warning on line 29 in src/modules/global/banners/banners.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5IMmkHOoPJ8sHDDU0E&open=AZ5IMmkHOoPJ8sHDDU0E&pullRequest=165

Check failure on line 159 in src/modules/admin/banners/admin-banners.service.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=CrisNAC_BackendMarketplace&issues=AZ5K6aU6SMXNKUU1ffJL&open=AZ5K6aU6SMXNKUU1ffJL&pullRequest=165
View more details on SonarQubeCloud