Fix preview CI missing preview version suffix - #61
Merged
Conversation
Agent-Logs-Url: https://github.com/CrestApps/CrestApps.Core/sessions/497da273-73da-4ba7-8dc2-c42b57f7d884 Co-authored-by: MikeAlhayek <24724371+MikeAlhayek@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
MikeAlhayek
April 30, 2026 19:40
View session
Member
|
@copilot it does not need the padding of 4 digits. it should only follow 1.0.0-preview-X where x is the run number. |
Agent-Logs-Url: https://github.com/CrestApps/CrestApps.Core/sessions/71514d18-45da-43a9-bd5c-68ec765f1904 Co-authored-by: MikeAlhayek <24724371+MikeAlhayek@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preview_ci.ymlwas not passing-p:VersionSuffix=previewtodotnet buildordotnet pack, causing packages to publish as1.0.0instead of1.0.0-preview-X.Changes
Set build number: switched from$(( $GITHUB_RUN_NUMBER ))to$GITHUB_RUN_NUMBERso the raw run number is used (e.g.1.0.0-preview-42)dotnet build: added/p:VersionSuffix=previewso built assemblies carry the suffixdotnet pack: added/p:VersionSuffix=previewso packed.nupkgfiles get the suffixDirectory.Build.propsalready has the wiring to appendBuildNumberwhenVersionSuffixis non-empty, so these additions are sufficient to restore1.0.0-preview-X-style versions.