Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ public override void Initializing(InitializingAIProviderConnectionContext contex
return;
}

if (!context.Connection.Has<AzureConnectionMetadata>())
{
return;
}

var metadata = context.Connection.GetOrCreate<AzureConnectionMetadata>();

context.Values["Endpoint"] = metadata.Endpoint?.ToString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ public override void Initializing(InitializingAIProviderConnectionContext contex
return;
}

var metadata = context.Connection.GetOrCreate<OpenAIConnectionMetadata>();
if (!context.Connection.TryGet<OpenAIConnectionMetadata>(out var metadata))
{
return;
}

if (!string.IsNullOrEmpty(metadata.ApiKey))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ public static AIProviderConnectionEntry Create(AIProviderConnection connection,

foreach (var value in context.Values)
{
if (value.Value == null)
{
continue;
}

values[value.Key] = value.Value;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,29 @@ public void Create_AppliesInitializingHandlersToStoredConnection()
Assert.Equal("eastus", entry["Region"]);
}

[Fact]
public void Create_DoesNotOverwriteExistingValuesWithNullHandlerValues()
{
var connection = new AIProviderConnection
{
Name = "azure-connection",
DisplayText = "Azure Connection",
ClientName = "azure-openai",
Properties = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase)
{
["Endpoint"] = "https://flat.openai.azure.com/",
["AuthenticationType"] = "ApiKey",
["ApiKey"] = "flat-key",
},
};

var entry = AIProviderConnectionEntryFactory.Create(connection, [new TestAzureConnectionHandler()]);

Assert.Equal("https://flat.openai.azure.com/", entry["Endpoint"]);
Assert.Equal("ApiKey", entry["AuthenticationType"]);
Assert.Equal("flat-key", entry["ApiKey"]);
}

private sealed class TestAzureConnectionHandler : IAIProviderConnectionHandler
{
public void Exporting(ExportingAIProviderConnectionContext context)
Expand All @@ -46,6 +69,11 @@ public void Exporting(ExportingAIProviderConnectionContext context)

public void Initializing(InitializingAIProviderConnectionContext context)
{
if (!context.Connection.Has<AzureConnectionMetadata>())
{
return;
}

var metadata = context.Connection.GetOrCreate<AzureConnectionMetadata>();

context.Values["Endpoint"] = metadata.Endpoint?.ToString();
Expand Down
Loading