Add More Elasticsearch Authentication Type - #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces expanded authentication and environment support for Elasticsearch data sources, along with related updates to infrastructure abstractions, documentation, and Azure AI Search integration. The main focus is on enabling Elastic Cloud deployments and supporting multiple authentication modes, while also simplifying localization handling in index profile descriptors.
Elasticsearch Data Source Enhancements:
CloudIdproperty and explicitEnvironmentTypeselection (SelfManagedorCloudHosted). The environment is now inferred or normalized via a helper method. [1] [2] [3]ApiKey,Base64ApiKey, andKeyIdAndKey, with corresponding protected properties (ApiKey,Base64ApiKey,ApiKeyId). The authentication type is now normalized based on provided credentials. [1] [2]Infrastructure and Localization Simplification:
IndexProfileSourceDescriptorto use plainstringforProviderDisplayName,DisplayName, andDescriptioninstead ofLocalizedString, and removed the unnecessaryMicrosoft.Extensions.Localizationimport. [1] [2]IndexProfileSourceOptionsto match the new string-based properties and added an overload forAddOrUpdateaccepting a string display name. [1] [2]DisplayNameandDescriptionas plain strings. [1] [2] [3]