Skip to content

Conversation

mollo010
Copy link

This is related to the pull request mc1.20.1/dev...hlysine:Create:fix/crafting-remaining-item.
It applies all this Some items in Minecraft contains "crafting remaining items" which are left behind when the item is used in crafting, e.g. empty buckets are left behind when crafting a cake with milk buckets. This is also how mods implement inconsumable crafting ingredients. However, over half of Create's recipe types do not respect this method, causing unexpected results such as #4853 and #4963.

Seeing that this issue has been in Create for years and I'm already patching one aspect of it in Create: Connected, I've decided to upstream the patch and fix all recipe types once and for all.

Recipe types that already return crafting remaining items include:

Automated shaped crafting
Mechanical crafting
Mixing
Compacting

Recipe types that did not return remaining items but are fixed in this PR include:

Crushing
Deploying
Fan processing (bulk blasting and smoking removes the remainder to be consistent with vanilla furnace behavior)
Manual item application
Milling
Pressing
Sandpaper polishing
Sawing

For your convenience, here's a datapack that adds all types of recipes for lava buckets, so you can verify that an empty bucket remains after processing: crafting-remaining-items-data.zip

To the current main branch and resolves the merge conflicts

@TheVigilantHawk
Copy link

This looks clean and well-implemented. Conflicts look resolved related to #4853 and #4963.
Highly recommend to push up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants