Skip to content

Fix sequenced assembly recipe misselection when recipes have the same transition item #9310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Fix sequenced assembly recipe misselection when recipes have the same transition item #9310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/main/java/com/simibubi/create/content/processing/sequenced/SequencedAssemblyRecipe.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,15 @@ private ItemStack rollResult() {
}

private boolean appliesTo(ItemStack input) {
if (ingredient.test(input))
return true;
return input.hasTag() && getTransitionalItem().getItem() == input.getItem() && input.getTag()
.contains("SequencedAssembly") && input.getTag()
.getCompound("SequencedAssembly")
.getString("id")
.equals(id.toString());
// First check if the item is already in the middle of a sequenced assembly recipe
if (input.hasTag() && input.getTag().contains("SequencedAssembly")) {
return getTransitionalItem().getItem() == input.getItem() && input.getTag()
.getCompound("SequencedAssembly")
.getString("id")
.equals(id.toString());
}
// Else it must be the first step in a new sequenced assembly recipe
return ingredient.test(input);
}

private SequencedRecipe<?> getNextRecipe(ItemStack input) {
Expand Down