Repository navigation
feat: add react-react-router extension - #314
ulises-jeremias merged 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds a React Router v7 extension with BrowserRouter wiring, sample Landing and About pages, route documentation, and template metadata. The default React Vite starter renders Landing without routing. Windows scaffold checks gain shell execution and file URL path normalization. ChangesReact Router v7 extension
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant App
participant BrowserRouter
participant AppRoutes
participant Page
App->>BrowserRouter: Mount with BASE_URL basename
BrowserRouter->>AppRoutes: Render routes
AppRoutes->>Page: Resolve / or /about
Page-->>App: Render page
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Align About with landing styles, tighten Doc typing, drop empty devDependencies, and restore templates.json trailing newline. Co-authored-by: Cursor <cursoragent@cursor.com>
Review notes — thank you @Tanmay-lanjewar! 🙏Really solid contribution. Moving React Router out of the base What looks great
Small follow-ups I pushed (maintainer edits)Pushed
No blockers found beyond that. Waiting on CI for the follow-up commit, then I'll approve and merge. Thanks again for shipping this — appreciated! |
ulises-jeremias
left a comment
There was a problem hiding this comment.
Approved — thank you again @Tanmay-lanjewar!
The extension cleanly delivers #279, CI is green across L0–L3 (including L2 · react-react-router @ react-vite-starter), and the follow-up polish commit looks good. Merging now.
|
Hey @Tanmay-lanjewar! Thanks again for contributing here. I recently put together a Discord for the OSS work around Create Awesome (Node / Python / V), agentic tooling, and a few related repos. Idea is to make collab a bit easier and slowly grow a small community around these projects. Invite if you want to join: https://discord.gg/bR5VyATgka We've got project channels (CNA, CPA, CVA, agentic-workstation, agentic-harness, recoil-devtools, dotfiles, rxv, etc), general chat, ideas/feedback, events, interest roles, and some voice rooms for hangouts or pairing. Totally optional. If you'd rather hang out somewhere lighter than GitHub issues, come say hi :) |
Summary
This PR adds a new
react-react-routerextension for React templates and moves React Router configuration out of the base React template.Changes
Base React Template
react-router-domdependency.BrowserRouterfrom the base template.AppRoutes.tsx.React Router Extension
react-router-domdependency.BrowserRouterconfiguration.AppRoutes.tsx.Aboutpage.Testing
node scripts/validate-templates.jsCloses #279
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
file://templates and scaffold subprocess execution.Updates