Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Password Protection and biometric authentication by Encrypted Shared Preferences and biometrics in android #125

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

anuragkanojiya1
Copy link
Contributor

@anuragkanojiya1 anuragkanojiya1 commented Oct 8, 2024

Related Issue

Closes: #115

Description

Implemented the password protection feature using encrypted shared preferences. This ensures that sensitive user data is securely stored in an offline mode and accessed only through proper authentication. Added logic to enable and disable password protection, and updated the settings screen to reflect the current state of the password protection feature.

Type of Change

1008.mp4
  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@CrazyMarvin
Copy link
Contributor

This is awesome!
Thank you very much for your input, @anuragkanojiya1. 👍

Would it be possible to use biometrics instead of a password too?

May you please make the new strings translateable (android/app/src/main/res/values/strings.xml )?

Can you please have a look too, @mubeen1519? What do you think?

@mubeen1519
Copy link
Contributor

sure will look into it but biometric feature are good approach for this app and convinent for user

@mubeen1519
Copy link
Contributor

actually its looks not too good to use password and this design also if biometric option is available we dont need to do this stuff only prompt show at start for biometric and user dont need to write and remember the password

@anuragkanojiya1
Copy link
Contributor Author

Okay, I will try to make a PR regarding biometric authentication soon.

@CrazyMarvin
Copy link
Contributor

I think both options would be great. So the users can decide if they go without extra protection, password or biometrics.

@CrazyMarvin
Copy link
Contributor

Thanks for giving a helping hand, @mubeen1519! ❤️

@anuragkanojiya1
Copy link
Contributor Author

I think both options would be great. So the users can decide if they go without extra protection, password or biometrics.

Okay @CrazyMarvin

@anuragkanojiya1
Copy link
Contributor Author

@CrazyMarvin I have implemented biometric auth and tested it on my physical device, it is working fine, you should check it out too.

@CrazyMarvin
Copy link
Contributor

May you share a debug APK please, @anuragkanojiya1?
May you please review the code, @mubeen1519?

@anuragkanojiya1
Copy link
Contributor Author

@CrazyMarvin Here's the debug apk.

debug.zip

@anuragkanojiya1 anuragkanojiya1 changed the title Added Password Protection by Encrypted Shared Preferences Added Password Protection and biometric authentication by Encrypted Shared Preferences and biometrics in android Oct 15, 2024
@anuragkanojiya1
Copy link
Contributor Author

@CrazyMarvin any update?

@mubeen1519
Copy link
Contributor

@CrazyMarvin Here's the debug apk.

debug.zip

the apk is not installing on my device android 10

@anuragkanojiya1
Copy link
Contributor Author

@CrazyMarvin Here's the debug apk.

debug.zip

the apk is not installing on my device android 10

It's working fine on my Android 10 device.

Screenshot_20241018-132213.jpg

Screenshot_20241018-132150.jpg

Screenshot_20241018-132314.jpg

@CrazyMarvin CrazyMarvin merged commit aa80a57 into Crazy-Marvin:development Oct 18, 2024
2 of 5 checks passed
@CrazyMarvin
Copy link
Contributor

I just merged your PR.

The UX needs a bit fine-tuning. Are you interested to do that next week?

Thanks!

@anuragkanojiya1
Copy link
Contributor Author

anuragkanojiya1 commented Oct 18, 2024

I just merged your PR.

The UX needs a bit fine-tuning. Are you interested to do that next week?

Thanks!


Sure @CrazyMarvin,
I’d love to connect with you on LinkedIn. You can find my profile here: Anurag Kanojiya.

Additionally, if you enjoy my work and would like to support me, you can check out my GitHub Sponsors profile: Sponsor My Work. Your support would mean a lot to me!

Looking forward to contribute more!

Best regards,
Anurag Kanojiya


@CrazyMarvin
Copy link
Contributor

The designer updated the mockup.
Are you able to create a new PR that reflects it, @anuragkanojiya1?

@anuragkanojiya1
Copy link
Contributor Author

The designer updated the mockup. Are you able to create a new PR that reflects it, @anuragkanojiya1?

Sure @CrazyMarvin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protection
3 participants