Add base RunSettings support for slurm, pbs, and cobalt #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricGustin
added
area: PBSpro
area: settings
al-rigazzi
reviewed
Oct 6, 2021
| settings = RunSettings(exe, args, run_command="srun", run_args=run_args) | ||
| return settings | ||
| if test_launcher == "pbs": | ||
| run_args = {"--pes": ntasks} |
There was a problem hiding this comment.
Is there a reason why we don't specify nodes and time for pbs and cobalt base settings?
There was a problem hiding this comment.
aprun doesn't have the concept of nodes. it's just processing elements.
Spartee
suggested changes
Oct 15, 2021
| @@ -77,6 +77,9 @@ def create_step(self, name, cwd, step_settings): | |||
| if isinstance(step_settings, MpirunSettings): | |||
| step = MpirunStep(name, cwd, step_settings) | |||
| return step | |||
| if isinstance(step_settings, RunSettings): | |||
There was a problem hiding this comment.
so lets say im on a slurm system and I put in the AprunSettings as my model run settings.
and the launcher doesn’t have AprunStep but it does have the base class… the launcher will still try to launch the AprunSettings as a LocalStep.
so then if I launch I would get this error
Traceback (most recent call last):
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/control/controller.py", line 359, in _launch_step
job_id = self._launcher.run(job_step)
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/launcher/slurm/slurmLauncher.py", line 159, in run
task_id = self.task_manager.start_task(
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/launcher/taskManager.py", line 124, in start_task
proc = execute_async_cmd(cmd_list, cwd, env=env, out=out, err=err)
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/launcher/util/shell.py", line 102, in execute_async_cmd
raise ShellError("Failed to run command", e, cmd_list) from None
smartsim.error.errors.ShellError: Failed to run command
Command: aprun /usr/bin/echo hello
Error from shell: [Errno 2] No such file or directory: 'aprun'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "hello.py", line 10, in <module>
exp.start(model)
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/experiment.py", line 103, in start
self._control.start(manifest=start_manifest, block=block)
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/control/controller.py", line 78, in start
self._launch(manifest)
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/control/controller.py", line 296, in _launch
self._launch_step(*job_step)
File "/lus/cls01029/spartee/poseidon/SmartSim/smartsim/control/controller.py", line 365, in _launch_step
raise SmartSimError(f"Job step {entity.name} failed to launch") from e
smartsim.error.errors.SmartSimError: Job step hello failed to launchThere was a problem hiding this comment.
this isn't a bad error but then the AprunSettings won't necessarily have all the arguments prepared correctly.
in order to correctly support custom run commands for each launcher type, the launcher.create_step function has been moved to the launcher parent class and a new class variable supported_rs now defines the preset RunSettings types supported by each launcher
EricGustin
force-pushed
the
runsettings-nonlocal
branch
from
6dc42a0
to
a22589c
Compare
… into runsettings-nonlocal Merge remote runsettings-nonlocal into local runsettings-nonlocal
… into runsettings-nonlocal Merge in remote
Spartee
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #84. The SmartSim
SlurmLauncher,PBSLauncher, andCobaltLaunchernow support baseRunSettings.Tested on slurm and pbs.