-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RedisAI Build #669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the SmartSim build process: - SmartSim can now be built using Cuda version 11.8 or Cuda 12.1 by specify `smart build --device=cuda118` or `smart build --device=cuda121`. The original `smart build --device=gpu` will default to using Cuda 11.8. - As a result of the previous change, SmartSim now requires C++17 and a minimum Cuda version of 11.8 in order to build Torch 2.1.0. - In addition this PR now uses Torch 2.1 and TF 2.14/2.15 (for CUDA 11.8/12.1 respectively) [ committed by @MattToast ] [ reviewed by @ashao ]
The existing dockerfiles did not have the necessary environments to enable GPU support for users wanting to run the tutorials. Two Dockerfiles (for CUDA 11.8 and 12.1) are provided. Note that this has only been tested on a workstation and no HPC support should be expected at this time. [ committed by @ashao ] [ reviewed by @MattToast ]
Add 'f' to intended f-strings for better error messages [ committed by @MattToast ] [ reviewed by @ashao ]
…into refactor_rai_builder
MattToast
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Such a nicer build system than was there previously!!
I just left some initial feedback while we resort out the CI and get everything building and passing. As always, feel free to lmk what you think!!
ashao
force-pushed
the
refactor_rai_builder
branch
from
September 18, 2024 06:43
70b7004
to
e69c271
Compare
MattToast
reviewed
Sep 18, 2024
smartsim/_core/_install/configs/mlpackages/LinuxX64CUDA125.json
Outdated
Show resolved
Hide resolved
ashao
force-pushed
the
refactor_rai_builder
branch
from
September 18, 2024 22:17
978b334
to
a617a2c
Compare
Small changes
Note not showing up correctly
ashao
force-pushed
the
refactor_rai_builder
branch
from
September 19, 2024 17:30
d54723e
to
a7d7161
Compare
ashao
force-pushed
the
refactor_rai_builder
branch
from
September 19, 2024 17:47
4ed07a7
to
0af872b
Compare
ashao
force-pushed
the
refactor_rai_builder
branch
from
September 19, 2024 17:48
0af872b
to
24e9d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
express a wider range of support for hardware/software stacks. This
will be extended to support ROCm, CUDA-11, and CUDA-12.
internal class. Instead a default set of JSON files specifies the
sources and versions. Users can specify their own custom specifications
at smart build time