Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove builder from setup.py #654

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

ashao
Copy link
Member

@ashao ashao commented Aug 1, 2024

The builder module was included in setup.py to allow us to ship the main Redis binaries (not RedisAI) with installs from PyPI. The changes in this PR remove our ability to do this and requires users to build Redis as part of the smart build. This change in behaviour is justified by the following:

  • The additional cost/complexity to the user for building Redis is minimal due to the pre-existing need to compile RedisAI.
  • Removes the need for different platform-dependent wheels
  • Frees the builder module from being a single file to allow convenient import into setup.py.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.97%. Comparing base (d7d979e) to head (795cdf5).
Report is 1 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (d7d979e) and HEAD (795cdf5). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (d7d979e) HEAD (795cdf5)
8 2
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #654       +/-   ##
============================================
- Coverage    83.91%   65.97%   -17.94%     
============================================
  Files           83       83               
  Lines         6284     6284               
============================================
- Hits          5273     4146     -1127     
- Misses        1011     2138     +1127     

see 47 files with indirect coverage changes

@ashao ashao requested review from MattToast and ankona August 1, 2024 19:35
# Define needed dependencies for the installation

# Add SmartRedis at specific version
# install_requires.append("smartredis>={}".format(versions.SMARTREDIS))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was a holdover from a previous PR

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small requests, but nothing worth holding approval up over.

LGTM, pending CI!!

setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@ashao ashao merged commit fde9f2e into CrayLabs:develop Aug 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants