Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building SmartSim without ML backends #601

Merged
merged 2 commits into from
May 24, 2024
Merged

Building SmartSim without ML backends #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfef2cb
Allow RedisAI library and backends to be installed individually. Othe…
m-kurz May 24, 2024
426f0d4
Update changelog
MattToast May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions doc/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,20 @@ To be released at some future point in time

Description

- Improve support for building SmartSim without ML backends
- Update packaging dependency

Detailed Notes

- Fix an error that would prevent ``smart build`` from moving a successfully
compiled RedisAI shared object to the install location expected by SmartSim
if no ML backend installations were found. Previously, this would effectively
require users to build and install an ML backend to use the SmartSim
orchestrator even if it was not necessary for their workflow. Users can
install SmartSim without ML backends by running
``smart build --no_tf --no_pt`` and the RedisAI shared object will now be
placed in the expected location.
([SmartSim-PR601](https://github.com/CrayLabs/SmartSim/pull/601))
- Fix packaging failures due to deprecated `pkg_resources`. ([SmartSim-PR598](https://github.com/CrayLabs/SmartSim/pull/598))

### 0.7.0
Expand Down
3 changes: 2 additions & 1 deletion smartsim/_core/_install/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,8 +705,9 @@ def _install_backends(self, device: Device) -> None:
rai_lib = self.rai_install_path / "redisai.so"
rai_backends = self.rai_install_path / "backends"

if rai_lib.is_file() and rai_backends.is_dir():
if rai_backends.is_dir():
self.copy_dir(rai_backends, self.lib_path / "backends", set_exe=True)
if rai_lib.is_file():
self.copy_file(rai_lib, self.lib_path / "redisai.so", set_exe=True)

def _move_torch_libs(self) -> None:
Expand Down
Loading