Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Uninitialized Variable Use #521

Merged
merged 7 commits into from
Mar 29, 2024

Conversation

MattToast
Copy link
Member

Configure mypy to error when a potentially uninitialized variable is used. Fix lingering errors found by mypy.

@MattToast MattToast self-assigned this Mar 14, 2024
@MattToast MattToast added short task Issues that can be completed and reviewed quickly type: refactor Issues focused on refactoring existing code bug: minor A minor bug labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.66%. Comparing base (fa0da2c) to head (0dd2768).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #521   +/-   ##
========================================
  Coverage    90.66%   90.66%           
========================================
  Files           65       65           
  Lines         4497     4498    +1     
========================================
+ Hits          4077     4078    +1     
  Misses         420      420           
Files Coverage Δ
smartsim/ml/tf/__init__.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short task, short review! LGTM!

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MattToast MattToast merged commit 6f800b1 into CrayLabs:develop Mar 29, 2024
44 checks passed
@MattToast MattToast deleted the no-undef-vars branch March 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: minor A minor bug non-user-facing short task Issues that can be completed and reviewed quickly type: refactor Issues focused on refactoring existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants